linux-kernel - Re: [PATCH] cdrom: move shared static to cdrom_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 08 Feb 2012 20:05:02 +0100
From:	Jens Axboe <axboe@...nel.dk>
To:	Paolo Bonzini <pbonzini@...hat.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cdrom: move shared static to cdrom_device_info

On 02/08/2012 06:32 PM, Paolo Bonzini wrote:
> The keeplocked variable in the cdrom driver is shared across multiple
> drives, but set in per-device ioctls.  Move it to the per-device struct,
> avoiding that the setting on one drive affects the driver's behavior
> when closing another.
> 
> [ Impact: limit udev's confusion to one drive when a CD burning program
>   unlocks the CD door at the end of burning. ]
> 
> Cc: Jens Axboe <axboe@...nel.dk>
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> ---
> 	Would this be acceptable for 3.3?

Yeah, looks simple enough. I thought we had a module parameter for this
too, but we do not. So I've applied it for 3.3.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/