linux-kernel - Re: [PATCH] rtlwifi/rtl8192c: in _rtl92c_phy_calculate_bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120208195744.GD2929@tuxdriver.com>
Date:	Wed, 8 Feb 2012 14:57:44 -0500
From:	"John W. Linville" <linville@...driver.com>
To:	Joe Perches <joe@...ches.com>
Cc:	"Devendra.Naga" <devendra.aaru@...il.com>,
	Larry.Finger@...inger.net, chaoming_li@...lsil.com.cn,
	paul.gortmaker@...driver.com, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtlwifi/rtl8192c: in _rtl92c_phy_calculate_bit_shift
 remove comparing bitmask against 1

On Mon, Jan 30, 2012 at 11:37:20PM -0800, Joe Perches wrote:
> On Tue, 2012-01-31 at 02:11 -0500, Devendra.Naga wrote:
> > From: "Devendra.Naga" <devendra.aaru@...il.com>
> []
> > diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
> []
> > @@ -177,7 +177,7 @@ u32 _rtl92c_phy_calculate_bit_shift(u32 bitmask)
> >  	u32 i;
> >  
> >  	for (i = 0; i <= 31; i++) {
> > -		if (((bitmask >> i) & 0x1) == 1)
> > +		if ((bitmask >> i) & 0x1)
> >  			break;
> >  	}
> >  	return i;
> 
> Perhaps this is simpler and faster:
> 
> {
> 	u32 rtn = (u32)ffs((int)bitmask);
> 	if (rtn)
> 		return rtn - 1;
> 	return 32;
> }

Are you planning to revise your patch based on Joe's suggestion?

-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/