linux-kernel - Re: [PATCH 23/50] efx: use dev_hw_addr_random() instead of random_ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1328736580.2627.9.camel@bwh-desktop>
Date:	Wed, 8 Feb 2012 21:29:40 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Danny Kukawka <danny.kukawka@...ect.de>
CC:	"David S. Miller" <davem@...emloft.net>,
	Danny Kukawka <dkukawka@...e.de>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	Solarflare linux maintainers <linux-net-drivers@...arflare.com>
Subject: Re: [PATCH 23/50] efx: use dev_hw_addr_random() instead of
 random_ether_addr()

On Wed, 2012-02-08 at 22:10 +0100, Danny Kukawka wrote:
> Use dev_hw_addr_random() instead of calling random_ether_addr()
> to set addr_assign_type correctly to NET_ADDR_RANDOM.
> 
> Reset the state to NET_ADDR_PERM as soon as the MAC get
> changed via .ndo_set_mac_address.
> 
> Signed-off-by: Danny Kukawka <danny.kukawka@...ect.de>
> ---
>  drivers/net/ethernet/sfc/efx.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
> index e43702f..cce339a 100644
> --- a/drivers/net/ethernet/sfc/efx.c
> +++ b/drivers/net/ethernet/sfc/efx.c
> @@ -940,7 +940,7 @@ static int efx_probe_port(struct efx_nic *efx)
>  			rc = -EINVAL;
>  			goto err;
>  		}
> -		random_ether_addr(efx->net_dev->dev_addr);
> +		dev_hw_addr_random(efx->net_dev, efx->net_dev->dev_addr);
>  		netif_info(efx, probe, efx->net_dev,
>  			   "using locally-generated MAC %pM\n",
>  			   efx->net_dev->dev_addr);
[...]

This code no longer exists in net-next.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/