| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120209094019.GA516@brouette> Date: Thu, 9 Feb 2012 10:40:19 +0100 From: Damien Wyart <damien.wyart@...e.fr> To: Wu Fengguang <fengguang.wu@...el.com> Cc: Shaohua Li <shaohua.li@...el.com>, Andrew Morton <akpm@...ux-foundation.org>, linux-fsdevel@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, Jens Axboe <axboe@...nel.dk> Subject: Re: [PATCH] block: remove plugging at buffered write time > > Done, thanks! Here is the updated patch with O_SYNC write fix. > Got these errors with the updated patch on top of 3.3-rc3: > fs/sync.c: In function 'vfs_fsync_range': > fs/sync.c:167:18: error: storage size of 'plug' isn't known > fs/sync.c:173:2: error: implicit declaration of function 'blk_start_plug' [-Werror=implicit-function-declaration] > fs/sync.c:175:2: error: implicit declaration of function 'blk_finish_plug' [-Werror=implicit-function-declaration] > fs/sync.c:167:18: warning: unused variable 'plug' [-Wunused-variable] Adding a #include <linux/blkdev.h> at the top of fs/sync.c solved the problem. Of course, this needs approval of a kernel developper before being added to the patch and resubmitted because I know adding #includes can have unwanted consequences sometimes or be seen as bloat... -- Damien Wyart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists