linux-kernel - Re: [PATCH] perf annotate: Numeric assembly labels cause incorrect annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120209133101.GC8830@elte.hu>
Date:	Thu, 9 Feb 2012 14:31:02 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Mike Galbraith <efault@....de>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Anton Blanchard <anton@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Frederic Weisbecker <fweisbec@...il.com>, emunson@...bm.net,
	imunsie@....ibm.com, eranian@...gle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf annotate: Numeric assembly labels cause incorrect
 annotation


* Mike Galbraith <efault@....de> wrote:

> On Tue, 2012-02-07 at 12:40 -0200, Arnaldo Carvalho de Melo wrote: 
> > Em Tue, Feb 07, 2012 at 02:55:35PM +1100, Anton Blanchard escreveu:
> > > 
> > > A perf annotate of a kernel function written in assembly shows
> > > very strange percentages:
> > 
> > Thanks! I think this is the same problem Mike Galbraith noticed and
> > reported me (I guess that was in a private message), Mike, can you
> > please test it so that I can add more Foo-by stamps to this one?
> 
> Sorry for the slow response (bz bz).
> 
> I don't see that problem, but perf top annotation isn't 
> working properly in tip at least.  It seems to have forgotten 
> how to average, seems to be clearing hit counts at every 
> screen refresh or something.

hm, seems to work fine here. We used to have such a bug recently 
(as of a few weeks [days?] ago), but latest -tip does not show 
those symptoms.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/