linux-kernel - Re: 8250 move broke the build on sparc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F344A85.4070005@windriver.com>
Date:	Thu, 9 Feb 2012 17:36:53 -0500
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	David Miller <davem@...emloft.net>
CC:	<linux-kernel@...r.kernel.org>, <gregkh@...uxfoundation.org>
Subject: Re: 8250 move broke the build on sparc

On 12-02-09 04:30 PM, David Miller wrote:
> 
> Commit 9bef3d4197379a995fa80f81950bbbf8d32e9e8b ("serial: group all
> the 8250 related code together") broke the build on sparc.
> 
> You really can't move 8250.c around without adjusting the "" includes
> such as the one for "suncore.h".

Understood.  As I mentioned earlier[1], I'd done sparc builds, but
completely missed the fact that sparc didn't have 8250 enabled
by default. Good intentions, but bad execution.  Sorry about
the fallout.  

> 
> Simply changing "suncore.h" to "../suncore.h" fixes things, but that's
> pretty ugly if you ask me.

It only uses suncore.h for sunserial_register_minors (and unreg).
Would you like it better if I killed all ifdefs and the include
and used an incantation of weak instead?  Might be cleaner....

P.

[1] https://lkml.org/lkml/2012/2/3/355
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/