linux-kernel - Re: [PATCH] Use NUMA node cpu mask in irq affinity [v2]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1202091449570.7219@chino.kir.corp.google.com>
Date:	Thu, 9 Feb 2012 14:51:30 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Prarit Bhargava <prarit@...hat.com>
cc:	linux-kernel@...r.kernel.org, Yinghai Lu <yinghai@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] Use NUMA node cpu mask in irq affinity [v2]

On Thu, 9 Feb 2012, Prarit Bhargava wrote:

> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index a9a9dbe..3064f2f 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -301,6 +301,13 @@ setup_affinity(unsigned int irq, struct irq_desc *desc, struct cpumask *mask)
>  	}
>  
>  	cpumask_and(mask, cpu_online_mask, set);
> +	if (desc->irq_data.node != -1) {

Should probably be using NUMA_NO_NODE.

> +		const struct cpumask *nodemask =
> +					   cpumask_of_node(desc->irq_data.node);
> +		/* make sure at least one of the cpus in nodemask is online */
> +		if (cpumask_intersects(mask, nodemask))
> +			cpumask_and(mask, mask, nodemask);
> +	}
>  	ret = chip->irq_set_affinity(&desc->irq_data, mask, false);
>  	switch (ret) {
>  	case IRQ_SET_MASK_OK:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/