linux-kernel - Re: [PATCH RFC v2] slab: introduce kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Feb 2012 15:06:52 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	Xi Wang <xi.wang@...il.com>, Jens Axboe <axboe@...nel.dk>,
	Pekka Enberg <penberg@...nel.org>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	linux-kernel@...r.kernel.org, Christoph Lameter <cl@...ux.com>,
	Matt Mackall <mpm@...enic.com>,
	David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH RFC v2] slab: introduce kmalloc_array

On Thu, 9 Feb 2012 23:47:42 +0100 (CET)
Jesper Juhl <jj@...osbits.net> wrote:

> > -static inline void *kcalloc(size_t n, size_t size, gfp_t flags)
> > +static inline void *kmalloc_array(size_t n, size_t size, gfp_t flags)
> >  {
> >  	if (size != 0 && n > ULONG_MAX / size)
> >  		return NULL;
> > -	return __kmalloc(n * size, flags | __GFP_ZERO);
> > +	return __kmalloc(n * size, flags);
> > +}
> > +
> > +/**
> > + * kcalloc - allocate memory for an array. The memory is set to zero.
> > + * @n: number of elements.
> > + * @size: element size.
> > + * @flags: the type of memory to allocate (see kmalloc).
> > + */
> > +static inline void *kcalloc(size_t n, size_t size, gfp_t flags)
> > +{
> > +	return kmalloc_array(n, size, flags | __GFP_ZERO);
> >  }
> >  
> >  #if !defined(CONFIG_NUMA) && !defined(CONFIG_SLOB)
> > 
> 
> Does this want adding to Documentation/CodingStyle "Chapter 14: Allocating 
> memory" ?

Spose so.  We could possibly cook up a checkpatch rule too ;)

<gad, CodingStyle has 18 chapters and an appendix??>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/