linux-kernel - Re: [PATCH v3 3/3] KVM: perf: kvm events analysis tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F333F34.4020007@gmail.com>
Date:	Wed, 08 Feb 2012 20:36:20 -0700
From:	David Ahern <dsahern@...il.com>
To:	Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>
CC:	Xiao Guangrong <xiaoguangrong.eric@...il.com>,
	Avi Kivity <avi@...hat.com>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Stefan Hajnoczi <stefanha@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH v3 3/3] KVM: perf: kvm events analysis tool


On 02/08/2012 08:07 PM, Xiao Guangrong wrote:
> Thanks for your review and explanation!
> 
> The code of commit_pager_choice():
> static void commit_pager_choice(void)
> {
> 	switch (use_pager) {
> 	case 0:
> 		setenv("PERF_PAGER", "cat", 1);
> 		break;
> 	case 1:
> 		/* setup_pager(); */
> 		break;
> 	default:
> 		break;
> 	}
> }
> 
> setup_pager() is not called.
> 
> And it looks like kvm-events can not show the result properly if
> i try to remove setup_pager.
> 
> 

You're right; I blew right past the fact that it is a comment.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/