linux-kernel - Re: [PATCH V1 1/2] mfd: tps65910: use regmap for device register access.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F335385.5040400@nvidia.com>
Date:	Thu, 9 Feb 2012 10:33:01 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"lrg@...com" <lrg@...com>,
	"jedu@...mlogic.co.uk" <jedu@...mlogic.co.uk>,
	"gg@...mlogic.co.uk" <gg@...mlogic.co.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH V1 1/2] mfd: tps65910: use regmap for device register
 access.

On Wednesday 08 February 2012 07:28 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Wed, Feb 08, 2012 at 07:04:14PM +0530, Laxman Dewangan wrote:
>> On Wednesday 08 February 2012 06:37 PM, Mark Brown wrote:
>>> Yes, though bulk_write() is tricky as it's *really* unclear what it
>>> should take as an argument - should it be raw register size (in which
>>> case it's just raw_write()) or should it be ints (in which case it needs
>>> to repack the data too)?  I suspect ints but I'm really not convinced
>>> there's much use case for this.
>>   * @map: Register map to write to
>>   * @reg: Initial register to write to
>>   * @val: Block of data to be written, laid out for direct transmission to the
>>   *       device
>>   * @@val_count: Number of registers to write
>> int regmap_bulk_write(struct regmap *map, unsigned int reg, void *val,
>>                       size_t val_count)
>> only support if map->format.parse_val not null like bulk_read.
>> It will just do the regamp_raw_write() if all regs are volatile
>> otherwise make the unsigned int from the val by function
>> map->format.parse_val for separate write for each register.
> But that's just raw_write(), there's no benefit to the additional API
> call.
>
raw_write supported for the volatile register only.
I require an api which can work for volatile as well as non-volatile 
registers.
Either extend raw_write to support both cases (remove warning and handle 
properly) or add bulk_write.

I think as bulk_read is there and so having bulk_write on same line 
should be OK.

> * Unknown Key
> * 0x6E30FDDD

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/