linux-kernel - Re: [PATCH 18/21] PCI: Fix cardbus bridge resources as optional size handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120210153546.GA5109@comet.dominikbrodowski.net>
Date:	Fri, 10 Feb 2012 16:35:46 +0100
From:	Dominik Brodowski <linux@...inikbrodowski.net>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Ram Pai <linuxram@...ibm.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 18/21] PCI: Fix cardbus bridge resources as optional size
 handling

On Sun, Feb 05, 2012 at 03:30:09PM -0800, Yinghai Lu wrote:
> On Sun, Feb 5, 2012 at 1:58 PM, Dominik Brodowski
> <linux@...inikbrodowski.net> wrote:
> > On Fri, Jan 27, 2012 at 01:37:44PM -0800, Yinghai Lu wrote:
> >> On Fri, Jan 27, 2012 at 10:23 AM, Jesse Barnes <jbarnes@...tuousgeek.org> wrote:
> >> > On Sat, 21 Jan 2012 02:08:34 -0800
> >> > Yinghai Lu <yinghai@...nel.org> wrote:
> >> >
> >> >> We should not set the requested size to -2.
> >> >>
> >> >> that will confuse the resource list sorting with align when SIZEALIGN is used.
> >> >>
> >> >> Change to STARTALIGN and pass align from start.
> >> >>
> >> >> We are safe to do that just as we do that regular pci bridge.
> >> >>
> >> >> In the long run, we should just treat cardbus like regular pci bridge.
> >> >>
> >> >> Also fix when realloc is not passed, should keep the requested size.
> >> >>
> >> >> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> >> >
> >> > I'd like to see some testing on this one... Dominik?
> >>
> >> Dominik,
> >>
> >> Can you please test branch at
> >>
> >>       git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git
> >> for-pci2
> >
> > Tested this on my limited test systems (COUNT=1), and seems to work fine.
> >
> 
> Thanks a lot.
> 
> Thought that you should have bunch of systems (laptop) with pci cardbus
> slots.
> 
> Found another regression by one commit already got into linus' tree.
> 
> and should be fixed by
> 
> [PATCH] pci: Fix pci cardbus removal
> 
> http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-yinghai.git;a=patch;h=29834f2faeed3cb87dea984a3d411337752e6b7c
> 
> please double check
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git for-pci3
> 
> or
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git
> for-pci-busn-alloc

I pulled both trees, and things still work fine on my test system.

Best,
	Dominik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/