linux-kernel - Re: [RFC] fs: filesystem specific options and remount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F354EFE.2080208@ubuntu.com>
Date:	Fri, 10 Feb 2012 12:08:14 -0500
From:	Phillip Susi <psusi@...ntu.com>
To:	Karel Zak <kzak@...hat.com>
CC:	Jan Kara <jack@...e.cz>, Jerome Marchand <jmarchan@...hat.com>,
	linux-fsdevel@...r.kernel.org, util-linux@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC] fs: filesystem specific options and remount

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/6/2012 6:08 PM, Karel Zak wrote:
> On Mon, Feb 06, 2012 at 11:41:16PM +0100, Jan Kara wrote:
>> On Fri 03-02-12 16:22:23, Jerome Marchand wrote:
>>> $ mount -o remount,hidepid=2 /proc/ $ grep proc /proc/mounts 
>>> /proc /proc proc rw,relatime,hidepid=2 0 0 $ mount | grep proc 
>>> proc on /proc type proc (rw,hidepid=2)
>>> 
>>> $ mount -o remount /proc/ $ grep proc /proc/mounts /proc /proc
>>> proc rw,relatime,hidepid=2 0 0 $ mount | grep proc proc on
>>> /proc type proc (rw)
> man mount:
> 
> The  remount  functionality follows the standard way how the mount 
> command works with options from fstab. It means the mount command 
> doesn't read fstab (or mtab) only when  a  device  and dir are
> fully specified.
> 
> mount -o remount,rw /dev/foo /dir
> 
> After this call all old mount options are replaced and arbitrary
> stuff from fstab is ignored, except the loop= option which is
> internally generated and maintained by the mount command.
> 
> mount -o remount,rw  /dir
> 
> After this call mount reads fstab (or mtab) and merges these
> options with options  from command line ( -o ).

Based on what you say there, I would guess this means that Jan has
proc listed in fstab, so mount tried to reset the mount options to
those specified in fstab, and the kernel proc fs left the options
unchanged.

It seems to me that the buggy behavior is in the proc fs not clearing
the unspecified options.  With the classic bitmask mount flags, any
that are not set are cleared by the remount, not left at their current
status.  This is why mount merges the existing flags specified in
fstab or mtab with those given on the command line.  The behavior
should be the same for the string passed mount flags.  In other words,
mount does its merging and whatever options are passed to the kernel
should be enabled, and any that are not should be disabled.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPNU7+AAoJEJrBOlT6nu75uyoH/3TxQOhOFGm2SlC0zwdh4Rld
/yotuzWpe27bjPHN9sychVEKeklhV+3kTHhK8DsiYwAHiJfwF2jyRFz9PTFYTmyj
7zLOi+7e7OFkLWxTADb4ihfqXZjEiI8TIK3RmsqAYLglRLPXw5VNgqGjoJx+7gfR
YKu9gzRUhjRKFvXoKGskdeGsB+em/PeAgy0qFYI2Et7rHekrX5PZvsjKsw8jqu/O
T9zDtbb0HBCub1PouB5leRc6HKuwdipmDrZFS1SV2ymbclMYh6WTkOJA4ngWGQm7
ZCwAqifcTHNvKr/CoAlFZ+m/9b85aAa9gb8vPUWNpZwEv5xpldhvWazGlR8gMkc=
=FTgE
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/