linux-kernel - Re: [PATCH] omap: board-omap3evm: add required smsc911x regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Feb 2012 09:40:47 -0800
From:	Tony Lindgren <tony@...mide.com>
To:	Matt Porter <matt@...orter.com>
Cc:	Russell King <linux@....linux.org.uk>, linux-omap@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] omap: board-omap3evm: add required smsc911x regulators

* Matt Porter <matt@...orter.com> [120208 13:35]:
> This fixes smsc911x support on omap3evm that has been broken since
> the smsc911x driver was updated to require the existence of vdd33a
> and vddvario supplies.

Great. Few comments:

1. Could you please include the smsc911x commit and subject here too
   so it clearly shows the regression?

2. Also, why don't you add this fixed regulator to gpmc-smsc911.c?

That way it gets fixed for other too, like zoom2/3.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/