linux-kernel - Re: [PATCH] perf tools: Allow multiple threads or processes in record, stat, top

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120210195857.GM2526@infradead.org>
Date:	Fri, 10 Feb 2012 17:58:58 -0200
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	David Ahern <dsahern@...il.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, peterz@...radead.org,
	fweisbec@...il.com, paulus@...ba.org, tglx@...utronix.de
Subject: Re: [PATCH] perf tools: Allow multiple threads or processes in
 record, stat, top

Em Fri, Feb 10, 2012 at 12:46:40PM -0700, David Ahern escreveu:
> On 02/10/2012 12:34 PM, Arnaldo Carvalho de Melo wrote:
> > I assume you tested it in a few scenarios (I know I did, but hey, more
> > testing is always good) and that I can add another stamp, a Tested-by:
> > ya, right?
> > 
> > - Arnaldo
> 
> Hmmm... that was a radical idea. Build breaks on Fedora 16, x86_64:
> 
> util/thread_map.c: In function ‘thread_map__new_by_pid_str’:
> util/thread_map.c:164:2: error: overflow in implicit constant conversion
> [-Werror=overflow]
> util/thread_map.c:175:3: error: comparison is always false due to
> limited range of data type [-Werror=type-limits]
> util/thread_map.c:175:3: error: comparison is always false due to
> limited range of data type [-Werror=type-limits]
> util/thread_map.c: In function ‘thread_map__new_by_tid_str’:
> util/thread_map.c:223:2: error: overflow in implicit constant conversion
> [-Werror=overflow]
> util/thread_map.c:245:3: error: comparison is always false due to
> limited range of data type [-Werror=type-limits]
> util/thread_map.c:245:3: error: comparison is always false due to
> limited range of data type [-Werror=type-limits]
> cc1: all warnings being treated as errors
> 
> 
> I think you want INT_MAX not LONG_MAX.

yeah, I tested it only on 32-bit :-\

I'll re-read the strtol man page and rework this patch, thanks for
testing!

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/