linux-kernel - Re: [PATCH] PM / Sleep: Remove unnecessary label from suspend_freeze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F35EC3C.5090305@linux.vnet.ibm.com>
Date:	Sat, 11 Feb 2012 09:49:08 +0530
From:	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
CC:	Linux PM list <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PM / Sleep: Remove unnecessary label from suspend_freeze_processes()

On 02/11/2012 05:05 AM, Rafael J. Wysocki wrote:

> From: Rafael J. Wysocki <rjw@...k.pl>
> 
> The Finish label in suspend_freeze_processes() is in fact necessary


s/necessary/unnecessary

> and makes the function look more complicated that it really is, so


s/that/than

> remove it (along with a few empty lines).
> 
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> ---
> 


Acked-by: Srivatsa S. Bhat <srivatsa.bhat@...ux.vnet.ibm.com>

Regards,
Srivatsa S. Bhat

> The patch is on top of linux-pm/pm-sleep.
> 
> Thanks,
> Rafael
> 
> ---
>  kernel/power/power.h |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> Index: linux/kernel/power/power.h
> ===================================================================
> --- linux.orig/kernel/power/power.h
> +++ linux/kernel/power/power.h
> @@ -234,16 +234,14 @@ static inline int suspend_freeze_process
>  	int error;
> 
>  	error = freeze_processes();
> -
>  	/*
>  	 * freeze_processes() automatically thaws every task if freezing
>  	 * fails. So we need not do anything extra upon error.
>  	 */
>  	if (error)
> -		goto Finish;
> +		return error;
> 
>  	error = freeze_kernel_threads();
> -
>  	/*
>  	 * freeze_kernel_threads() thaws only kernel threads upon freezing
>  	 * failure. So we have to thaw the userspace tasks ourselves.
> @@ -251,7 +249,6 @@ static inline int suspend_freeze_process
>  	if (error)
>  		thaw_processes();
> 
> - Finish:
>  	return error;
>  }
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/