linux-kernel - Re: [PATCH resend] asm/types.h: All architectures use int-ll64.h in kernelspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120211094444.GL23916@ZenIV.linux.org.uk>
Date:	Sat, 11 Feb 2012 09:44:44 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	linux-arch@...r.kernel.org, linux-doc@...r.kernel.org,
	Linux Kernel Development <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH resend] asm/types.h: All architectures use int-ll64.h in
 kernelspace

On Sat, Aug 13, 2011 at 11:25:59PM +0200, Arnd Bergmann wrote:
> On Saturday 13 August 2011 21:53:43 Geert Uytterhoeven wrote:
> > Now all 64-bit architectures have been converted to int-ll64.h, we can
> > deprecate int-l64.h in kernelspace:
> >   - Add a check to prevent new architectures from using int-l64.h in
> >     kernelspace,
> >   - Update documentation, as the casts to (unsigned) long long are no longer
> >     needed.
> > 
> > For backwards compatibility, alpha, ia64, mips, and powerpc still use
> > int-l64.h in userspace.
> > 
> > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> > For the documentation parts:
> > Acked-by: Randy Dunlap <rdunlap@...otime.net>
> 
> I believe that Al Viro is working on a patch to unify all umode_t definitions
> so that it becomes unsigned short everywhere. Once that is done,
> asm-generic/int-ll64.h can become asm-generic/types.h and all architectures
> can use that.

Umm...  That has happened and yes, asm-generic/types.h is currently
equivalent to asm-generic/int-ll64.h.  What exactly are you planning
to do?  Just rename the latter to the former and do search-and-replace
over the tree?  We still have places that pull int-l64.h, albeit only
!__KERNEL__ ones (i.e. everything under #ifdef __KERNEL__ in there
seems to be killable)...

AFAICS, for quite a few of those guys we can simply add bitsperlong.h
and add types.h to generic-y; is that the plan?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/