linux-kernel - Re: [PATCH 2/2] PM / QoS: unconditionally build the per-device constraints feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120212020757.GF18742@gs62>
Date:	Sat, 11 Feb 2012 18:07:57 -0800
From:	mark gross <markgross@...gnar.org>
To:	Jean Pihet <jean.pihet@...oldbits.com>
Cc:	Linux PM mailing list <linux-pm@...ts.linux-foundation.org>,
	linux-kernel@...r.kernel.org, "Rafael J. Wysocki" <rjw@...k.pl>,
	Mark Gross <markgross@...gnar.org>,
	Venkatesh Pallipadi <venki@...gle.com>,
	Jean Pihet <j-pihet@...com>
Subject: Re: [PATCH 2/2] PM / QoS: unconditionally build the per-device
 constraints feature

why are these two patches?

I think you could squash them into one and it would be just fine.

--mark

On Tue, Feb 07, 2012 at 09:34:06AM +0100, Jean Pihet wrote:
> The per-device PM QoS feature depends on CONFIG_PM which depends
> on PM_SLEEP || PM_RUNTIME. This breaks CPU C-states with kernels
> not having these CONFIGs.
> 
> This patch allows the feature in all cases.
> 
> Signed-off-by: Jean Pihet <j-pihet@...com>
> Cc: Rafael J. Wysocki <rjw@...k.pl>
> Cc: Mark Gross <markgross@...gnar.org>
> ---
>  drivers/base/power/Makefile |    3 ++-
>  include/linux/pm_qos.h      |   39 ---------------------------------------
>  2 files changed, 2 insertions(+), 40 deletions(-)
> 
> diff --git a/drivers/base/power/Makefile b/drivers/base/power/Makefile
> index 2e58ebb..312eb65 100644
> --- a/drivers/base/power/Makefile
> +++ b/drivers/base/power/Makefile
> @@ -1,4 +1,5 @@
> -obj-$(CONFIG_PM)	+= sysfs.o generic_ops.o common.o qos.o
> +obj-y			+= qos.o
> +obj-$(CONFIG_PM)	+= sysfs.o generic_ops.o common.o
>  obj-$(CONFIG_PM_SLEEP)	+= main.o wakeup.o
>  obj-$(CONFIG_PM_RUNTIME)	+= runtime.o
>  obj-$(CONFIG_PM_TRACE_RTC)	+= trace.o
> diff --git a/include/linux/pm_qos.h b/include/linux/pm_qos.h
> index 105be69..37b017a 100644
> --- a/include/linux/pm_qos.h
> +++ b/include/linux/pm_qos.h
> @@ -77,7 +77,6 @@ int pm_qos_remove_notifier(int pm_qos_class, struct notifier_block *notifier);
>  int pm_qos_request_active(struct pm_qos_request *req);
>  s32 pm_qos_read_value(struct pm_qos_constraints *c);
>  
> -#ifdef CONFIG_PM
>  s32 __dev_pm_qos_read_value(struct device *dev);
>  s32 dev_pm_qos_read_value(struct device *dev);
>  int dev_pm_qos_add_request(struct device *dev, struct dev_pm_qos_request *req,
> @@ -94,43 +93,5 @@ void dev_pm_qos_constraints_init(struct device *dev);
>  void dev_pm_qos_constraints_destroy(struct device *dev);
>  int dev_pm_qos_add_ancestor_request(struct device *dev,
>  				    struct dev_pm_qos_request *req, s32 value);
> -#else
> -static inline s32 __dev_pm_qos_read_value(struct device *dev)
> -			{ return 0; }
> -static inline s32 dev_pm_qos_read_value(struct device *dev)
> -			{ return 0; }
> -static inline int dev_pm_qos_add_request(struct device *dev,
> -					 struct dev_pm_qos_request *req,
> -					 s32 value)
> -			{ return 0; }
> -static inline int dev_pm_qos_update_request(struct dev_pm_qos_request *req,
> -					    s32 new_value)
> -			{ return 0; }
> -static inline int dev_pm_qos_remove_request(struct dev_pm_qos_request *req)
> -			{ return 0; }
> -static inline int dev_pm_qos_add_notifier(struct device *dev,
> -					  struct notifier_block *notifier)
> -			{ return 0; }
> -static inline int dev_pm_qos_remove_notifier(struct device *dev,
> -					     struct notifier_block *notifier)
> -			{ return 0; }
> -static inline int dev_pm_qos_add_global_notifier(
> -					struct notifier_block *notifier)
> -			{ return 0; }
> -static inline int dev_pm_qos_remove_global_notifier(
> -					struct notifier_block *notifier)
> -			{ return 0; }
> -static inline void dev_pm_qos_constraints_init(struct device *dev)
> -{
> -	dev->power.power_state = PMSG_ON;
> -}
> -static inline void dev_pm_qos_constraints_destroy(struct device *dev)
> -{
> -	dev->power.power_state = PMSG_INVALID;
> -}
> -static inline int dev_pm_qos_add_ancestor_request(struct device *dev,
> -				    struct dev_pm_qos_request *req, s32 value)
> -			{ return 0; }
> -#endif
>  
>  #endif
> -- 
> 1.7.5.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/