linux-kernel - Re: [PATCH] HID: use generic driver for Logitech Unifying receivers if CONFIG_HID_LOGITECH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE7qMroBw6G5c-dWjwTneuLchwO=m9FdLaYLwajncbZU4VjE1w@mail.gmail.com>
Date:	Mon, 13 Feb 2012 10:31:26 +0100
From:	Nestor Lopez Casado <nlopezcasad@...itech.com>
To:	Konstantin Khlebnikov <khlebnikov@...nvz.org>
Cc:	Jiri Kosina <jkosina@...e.cz>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@...il.com>
Subject: Re: [PATCH] HID: use generic driver for Logitech Unifying receivers
 if CONFIG_HID_LOGITECH_DJ=n

On Mon, Feb 13, 2012 at 10:15 AM, Konstantin Khlebnikov
<khlebnikov@...nvz.org> wrote:
> Nestor Lopez Casado wrote:
>>
>> Hi Konstantin,
>>
>> This was the original implementation
>> http://www.spinics.net/lists/linux-input/msg15225.html
>> Jiri suggested we removed the conditional compilation and we accepted.
>>
>> Which are your reasons to add those conditionals back again?
>
>
> This device can work perfectly without special driver. It does not add
> any special advantage if there only one mouse and/or one keyboard device.
> So, I don't see any reason for this strictly requirement of special driver.

I'm OK with that. It's Jiri's call.

Nevertheless, if you change that, please change the description on
Kconfig to reflect the fact that the receiver would work even without
the driver.

Nestor.

>
>
>>
>> Cheers,
>>
>> Nestor
>>
>> On Mon, Feb 13, 2012 at 9:06 AM, Konstantin Khlebnikov
>> <khlebnikov@...nvz.org>  wrote:
>>>
>>> Before commit 534a7b8e1 "HID: Add full support for Logitech Unifying
>>> receivers"
>>> Logitech Unifying receiver can work as generic device without special
>>> driver,
>>> after that commit these devices does not works without special driver.
>>>
>>> After this patch they will use generic driver if special driver is
>>> disabled.
>>>
>>> Signed-off-by: Konstantin Khlebnikov<khlebnikov@...nvz.org>
>>> ---
>>>  drivers/hid/hid-core.c |    2 ++
>>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
>>> index af08ce7..3d7a174 100644
>>> --- a/drivers/hid/hid-core.c
>>> +++ b/drivers/hid/hid-core.c
>>> @@ -1462,8 +1462,10 @@ static const struct hid_device_id
>>> hid_have_special_driver[] = {
>>>        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
>>> USB_DEVICE_ID_LOGITECH_DFGT_WHEEL) },
>>>        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
>>> USB_DEVICE_ID_LOGITECH_G25_WHEEL) },
>>>        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
>>> USB_DEVICE_ID_LOGITECH_G27_WHEEL) },
>>> +#if IS_ENABLED(CONFIG_HID_LOGITECH_DJ)
>>>        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
>>> USB_DEVICE_ID_LOGITECH_UNIFYING_RECEIVER) },
>>>        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
>>> USB_DEVICE_ID_LOGITECH_UNIFYING_RECEIVER_2) },
>>> +#endif
>>>        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
>>> USB_DEVICE_ID_LOGITECH_WII_WHEEL) },
>>>        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
>>> USB_DEVICE_ID_LOGITECH_RUMBLEPAD2) },
>>>        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
>>> USB_DEVICE_ID_SPACETRAVELLER) },
>>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/