linux-kernel - Re: [PATCH 2/2] usb: fix renesas_usbhs to not schedule in atomic context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120213120814.GP6614@legolas.emea.dhcp.ti.com>
Date:	Mon, 13 Feb 2012 14:08:15 +0200
From:	Felipe Balbi <balbi@...com>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	linux-usb@...r.kernel.org, Felipe Balbi <balbi@...com>,
	"Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@...esas.com>,
	linux-sh@...r.kernel.org, Magnus Damm <magnus.damm@...il.com>,
	linux-kernel@...r.kernel.org, Vinod Koul <vinod.koul@...el.com>,
	Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [PATCH 2/2] usb: fix renesas_usbhs to not schedule in atomic
 context

Hi,

On Thu, Feb 09, 2012 at 11:17:51PM +0100, Guennadi Liakhovetski wrote:
> @@ -997,7 +991,7 @@ static bool usbhsf_dma_filter(struct dma_chan *chan, void *param)
>  	 *
>  	 * usbhs doesn't recognize id = 0 as valid DMA
>  	 */
> -	if (0 == slave->slave_id)
> +	if (0 == slave->simple_slave.slave_id)
>  		return false;
>  
>  	chan->private = slave;
> @@ -1176,8 +1170,8 @@ int usbhs_fifo_probe(struct usbhs_priv *priv)
>  	fifo->port	= D0FIFO;
>  	fifo->sel	= D0FIFOSEL;
>  	fifo->ctr	= D0FIFOCTR;
> -	fifo->tx_slave.slave_id	= usbhs_get_dparam(priv, d0_tx_id);
> -	fifo->rx_slave.slave_id	= usbhs_get_dparam(priv, d0_rx_id);
> +	fifo->tx_slave.simple_slave.slave_id	= usbhs_get_dparam(priv, d0_tx_id);
> +	fifo->rx_slave.simple_slave.slave_id	= usbhs_get_dparam(priv, d0_rx_id);

what are these "simple_slave" changes ? They have nothing to do with
$SUBJECT ? In fact, breaks my gadget branch.

How many times does a maintainer have to ask for contributors to keep
changes atomic ? One patch == One single, self-contained, change.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)