linux-kernel - Re: Pe: [PATCH v5 1/3] virtio-scsi: first version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN05THTOY894httm5PjzsHELBB-P8DmpZ4bGoBR7FH1s6Tmcrg@mail.gmail.com>
Date:	Tue, 14 Feb 2012 00:13:36 +1100
From:	ronnie sahlberg <ronniesahlberg@...il.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	Dor Laor <dlaor@...hat.com>,
	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
	Christian Borntraeger <borntraeger@...ibm.com>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Paolo Bonzini <pbonzini@...hat.com>,
	Christian Hoff <christian.hoff@...ibm.com>,
	borntrae@...ux.vnet.ibm.com, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	rusty@...tcorp.com.au, Stefan Hajnoczi <stefanha@...il.com>,
	target-devel <target-devel@...r.kernel.org>
Subject: Re: Pe: [PATCH v5 1/3] virtio-scsi: first version

On Tue, Feb 14, 2012 at 12:00 AM, Michael S. Tsirkin <mst@...hat.com> wrote:
> On Mon, Feb 13, 2012 at 02:54:03PM +0200, Dor Laor wrote:
>> Only if you use the pci multi-function option but that kills
>> standard hot unplug
>
> It doesn't kill it as such, rather you can't unplug luns individually.

Isnt that just a consequence of the current implementation rather than
a SCSI limitation?

A different way to do hoplug could be to flag all devices as removable
in the standard inq page then
leave the LUN there persistently and what you remove/add is not the
LUN device itself but just the media in the device.

Instead of hot-plug remove the LUN,  hot-plug becomes "media eject" or
"media insert".
The device remains present all time, you never remove it, but instead
hot-plug controls if the media is present or not.

This would require implementing at least START_STOP_UNIT and
PREVENT_ALLOW_MEDIUM_REMOVAL opcode emulation from SBC.

regards
ronnie sahlberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/