linux-kernel - Re: linux-next: build failure after merge of the final tree (staging tree related)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 Feb 2012 07:03:09 -0800
From:	Greg KH <greg@...ah.com>
To:	Seth Jennings <sjenning@...ux.vnet.ibm.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Nitin Gupta <ngupta@...are.org>
Subject: Re: linux-next: build failure after merge of the final tree (staging
 tree related)

On Mon, Feb 13, 2012 at 08:48:05AM -0600, Seth Jennings wrote:
> On 02/13/2012 12:45 AM, Greg KH wrote:
> > On Mon, Feb 13, 2012 at 05:19:49PM +1100, Stephen Rothwell wrote:
> >> Hi ,
> >>
> >> After merging the final tree, today's linux-next build (powerpc allyesconfig)
> >> failed like this:
> >>
> >> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_cpu_notifier':
> >> drivers/staging/zsmalloc/zsmalloc-main.c:451:3: error: implicit declaration of function 'alloc_vm_area' [-Werror=implicit-function-declaration]
> >> drivers/staging/zsmalloc/zsmalloc-main.c:451:12: warning: assignment makes pointer from integer without a cast [enabled by default]
> >> drivers/staging/zsmalloc/zsmalloc-main.c:459:4: error: implicit declaration of function 'free_vm_area' [-Werror=implicit-function-declaration]
> >> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_map_object':
> >> drivers/staging/zsmalloc/zsmalloc-main.c:705:3: error: implicit declaration of function 'set_pte' [-Werror=implicit-function-declaration]
> >> drivers/staging/zsmalloc/zsmalloc-main.c:709:27: error: dereferencing pointer to incomplete type
> >> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_unmap_object':
> >> drivers/staging/zsmalloc/zsmalloc-main.c:739:3: error: implicit declaration of function '__flush_tlb_one' [-Werror=implicit-function-declaration]
> >>
> >> Caused by commit 61989a80fb3a ("staging: zsmalloc: zsmalloc memory
> >> allocation library").  This needs to include linux/vmalloc.h at least.  I
> >> couldn't find set_pte at all or __flush_tlb_one for powerpc.
> >>
> >> This was too hard to revert, so I have left powerpc allyesconfig broken
> >> for today.  I may revert it (and some dependent commits) tomorrow.
> > 
> > Nitin, please send me a patch to fix this as soon as possible.
> 
> Sending a patch now.  Adds linux/vmalloc.h to zsmalloc-main.c. On a less ideal
> note, it also adds an X86 dependency since set_pte and __flush_tlb_one are
> x86 only.  I'm working to find portable replacements for these functions.

Thanks for the patch, I'll queue it up.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/