linux-kernel - Re: [PATCH] drm/i915: Fix single msg gmbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <e0d58a$38gbj5@orsmga002.jf.intel.com>
Date:	Mon, 13 Feb 2012 21:49:35 +0000
From:	Chris Wilson <chris@...is-wilson.co.uk>
To:	Daniel Vetter <daniel@...ll.ch>, Benson Leung <bleung@...omium.org>
Cc:	keithp@...thp.com, airlied@...ux.ie, djkurtz@...omium.org,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix single msg gmbus_xfers writes

On Mon, 13 Feb 2012 21:38:38 +0100, Daniel Vetter <daniel@...ll.ch> wrote:
> This here looks like just a white-space change. But your commit message
> sounds like it's not jsut write's that are affected by this issue and need
> to be fixed. Can you please clear up this for easily confused me?

It makes the write path similar to the read path. I admit to overlooking
the single write message as everything I saw was always a write followed
by a read. The patch looks correct, but I need to stare at it a bit more
before I r-b.

However, the outstanding issue is that we need to separate the gmbus
i2c adapter from the gpio i2c adapter in order for the pairing to work
with the expectations of the i2c core.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/