linux-kernel - Re: [PATCH] modpost: Fix section warnings for ARM for many compilers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Feb 2012 22:51:18 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org,
	Anders Kaseorg <andersk@...lice.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Greg KH <gregkh@...uxfoundation.org>,
	linux-omap@...r.kernel.org, Ben Hutchings <ben@...adent.org.uk>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] modpost: Fix section warnings for ARM for many
	compilers

On Mon, Feb 13, 2012 at 11:26:52PM +0100, Uwe Kleine-König wrote:
> On Mon, Feb 13, 2012 at 01:24:01PM -0800, Tony Lindgren wrote:
> > It turns out that many compilers don't show section warnings on ARM
> > currently because handling for ARM_CALL relocs are missing from
> > modpost.c.
> > 
> > Based on commit c2e26114 ([ARM] 3205/1: Handle new EABI relocations when
> > loading kernel modules) it seems that R_ARM_PC24, R_ARM_CALL and
> > R_ARM_JUMP24 can be handled the same way.
> > 
> > As modpost.c includes elf.h, we need to also consider that at least
> > Debian libc6-dev is missing defines for both R_ARM_CALL and R_ARM_JUMP24
> > in /usr/include/elf.h.
> Huh, even unstable's /usr/include/elf.h doesn't have these symbols.
> 
> > So for now let's just use the numbers in modpost.c.
> > 
> > Cc: Rusty Russell <rusty@...tcorp.com.au>
> > Cc: Ben Hutchings <ben@...adent.org.uk>
> > Cc: Anders Kaseorg <andersk@...lice.com>
> > Cc: Greg KH <gregkh@...uxfoundation.org>
> > Cc: Russell King <rmk+kernel@....linux.org.uk>
> > Signed-off-by: Tony Lindgren <tony@...mide.com>
> > 
> > ---
> > 
> > Anybody got better ideas for dealing with the missing elf.h
> > defines?
> Maybe:
> 
> #ifndef R_ARM_CALL
> #warning "you're elf.h include is outdated"

"You are elf.h include is outdated" does not make sense.

Why are you calling Tony an elf.h include?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/