linux-kernel - Re: [PATCH block/for-linus] block: blk-throttle should be drained regardless of q->elevator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120213234057.GI12117@google.com>
Date:	Mon, 13 Feb 2012 15:40:57 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH block/for-linus] block: blk-throttle should be drained
 regardless of q->elevator

Hello,

On Mon, Feb 13, 2012 at 06:27:42PM -0500, Vivek Goyal wrote:
> > -	/*
> > -	 * Drain all requests queued before DEAD marking.  The caller might
> > -	 * be trying to tear down @q before its elevator is initialized, in
> > -	 * which case we don't want to call into draining.
> > -	 */
> > -	if (q->elevator)
> > -		blk_drain_queue(q, true);
> > +	/* drain all requests queued before DEAD marking */
> 
> We have already marked the queue DEAD before we start draining the queue.
> May be we need to fix the comment.

Hmmm... it actually is correct.  It drains all requests which were
queued before the preceding DEAD marking.  ie... it's describing the
following.

	1. requests queued
	2. mark q DEAD
	3. drain requests which were queued before #2.  We don't care
	   about requests queued after #2.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/