linux-kernel - Re: [PATCH 2/2] bluetooth: Convert BT_DBG to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1329115904.30878.7.camel@joe2Laptop>
Date:	Sun, 12 Feb 2012 22:51:44 -0800
From:	Joe Perches <joe@...ches.com>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	"Gustavo F. Padovan" <padovan@...fusion.mobi>,
	"David S. Miller" <davem@...emloft.net>,
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] bluetooth: Convert BT_DBG to pr_debug

On Mon, 2012-02-13 at 07:37 +0100, Marcel Holtmann wrote:
> > No need to obfuscate, just use the normal debugging macro.
> > Add "\n" to uses, align arguments, coalesce formats.
> > Fix a typo and fix a bad format extended by a line continuation.
> what is this patch buying us.

Easier greps of pr_debug.
BT_DBG is just an unnecessary useless wrapper.

> The only useful change would be to move to dev_printk, but we are not
> there yet.

Maybe dev_dbg, but there isn't always an
appropriate device * available.

There are many uses of:
	pr_debug("%s ...", (some struct hci_dev *)->name, ...)

that could be something like

hci_dev_dbg((some struct hci_dev *), fmt, ...)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/