linux-kernel - Re: [PATCH] KEYS: Enable the compat keyctl wrapper on s390x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F3A785A.4030500@de.ibm.com>
Date:	Tue, 14 Feb 2012 16:06:02 +0100
From:	Christian Borntraeger <borntraeger@...ibm.com>
To:	David Howells <dhowells@...hat.com>
CC:	keyrings@...ux-nfs.org, linux-kernel@...r.kernel.org, dan@...ny.cz,
	Carsten Otte <cotte@...ibm.com>, linux-s390@...r.kernel.org,
	stable@...r.kernel.org, Heiko Carstens <heiko.carstens@...ibm.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>
Subject: Re: [PATCH] KEYS: Enable the compat keyctl wrapper on s390x

On 14/02/12 15:50, David Howells wrote:
> Enable the compat keyctl wrapper on s390x so that 32-bit s390 userspace can
> call the keyctl() syscall.
> 
> There's an s390x assembly wrapper that truncates all the register values to
> 32-bits and this then calls compat_sys_keyctl() - but the latter only exists if
> CONFIG_KEYS_COMPAT is enabled, and the s390 Kconfig doesn't enable it.
> 
> Without this patch, 32-bit calls to the keyctl() syscall are given an ENOSYS
> error:
> 
> 	[root@...el4 ~]# keyctl show
> 	Session Keyring
> 	-3: key inaccessible (Function not implemented)
> 
> Signed-off-by: David Howells <dhowells@...hat.com>
> Acked-by: dan@...ny.cz
> cc: Carsten Otte <cotte@...ibm.com>
> cc: Christian Borntraeger <borntraeger@...ibm.com>
> cc: linux-s390@...r.kernel.org
> cc: stable@...r.kernel.org

Patch looks sane.
Reviewed-by: Christian Borntraeger <borntraeger@...ibm.com>

Do you want to push this change via Martins s390 tree or via other
trees?

> ---
> 
>  arch/s390/Kconfig |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> index d172758..6d99a5f 100644
> --- a/arch/s390/Kconfig
> +++ b/arch/s390/Kconfig
> @@ -227,6 +227,9 @@ config COMPAT
>  config SYSVIPC_COMPAT
>  	def_bool y if COMPAT && SYSVIPC
> 
> +config KEYS_COMPAT
> +	def_bool y if COMPAT && KEYS
> +
>  config AUDIT_ARCH
>  	def_bool y
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/