linux-kernel - Re: [PATCH] staging: fix powerpc linux-next break on zsmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5736714.Unq6oKkpjO@ax5200p>
Date:	Tue, 14 Feb 2012 17:21:05 +0100
From:	Marc Dietrich <marvin24@....de>
To:	Seth Jennings <sjenning@...ux.vnet.ibm.com>
Cc:	Greg KH <greg@...ah.com>, Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Nitin Gupta <ngupta@...are.org>
Subject: Re: [PATCH] staging: fix powerpc linux-next break on zsmalloc

Hi Seth,

On Tuesday 14 February 2012 08:35:13 Seth Jennings wrote:
> On 02/14/2012 05:39 AM, Marc Dietrich wrote:
> > Am 14.02.2012 12:22, schrieb Marc Dietrich:
> >> Am 13.02.2012 15:47, schrieb Seth Jennings:
> >>> linux/vmalloc.h added to zsmalloc-main.c to resolve implicit
> >>> declaration errors.
> >>> 
> >>> X86 dependency added to zsmalloc and dependent drivers zcache and
> >>> zram.
> >>> 
> >>> This X86 only requirement is not ideal.  Working to find portable
> >>> functions for __flush_tlb_one and set_pte.
> >> 
> >> sorry, zcache/zram works fine one ARM here. Why not depend on
> >> !POWERPC?
> > 
> > ups, sorry again, I tested an older version only. flush_tlb_one and
> > set_pte is only used with the new allocator as it seems.
> 
> It would seem that the cpu-local tlb page flushing function for ARM
> is local_flush_tlb_kernel_page(), by look at the kmap_atomic() code
> in arch/arm/mm/highmem.c.
> 
> So each arch is using a slightly different approach here.
> 
> A simple #define per-arch could make a it a common call.  I think
> I'm going to code it up and see how it goes.

... and I'm happy to test it ;-)

Thanks

Marc

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/