linux-kernel - Re: [PATCH 21/21] posix_types: Remove fd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F3AC0B4.1020203@intel.com>
Date:	Tue, 14 Feb 2012 12:14:44 -0800
From:	"H. Peter Anvin" <h.peter.anvin@...el.com>
To:	David Howells <dhowells@...hat.com>
CC:	Tony Luck <tony.luck@...el.com>, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 21/21] posix_types: Remove fd_set macros

On 02/14/2012 11:44 AM, H. Peter Anvin wrote:
> 
> We can do that, but we'd almost certainly have to #include
> <linux/select.h> in <linux/time.h>.  The following macros are defined in
> <linux/time.h> and *exported to userspace*:
> 
> #define NFDBITS                 __NFDBITS
> 
> #define FD_SETSIZE              __FD_SETSIZE
> #define FD_SET(fd,fdsetp)       __FD_SET(fd,fdsetp)
> #define FD_CLR(fd,fdsetp)       __FD_CLR(fd,fdsetp)
> #define FD_ISSET(fd,fdsetp)     __FD_ISSET(fd,fdsetp)
> #define FD_ZERO(fdsetp)         __FD_ZERO(fdsetp)
> 

Note: yes, those macros are completely useless, obviously, since all
they do is take what is already defined in userspace and reflect it back
out.  Still, removing them is a userspace-visible change and really
should be its own change with nothing else.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/