lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Feb 2012 09:43:11 +0100 From: Jens Axboe <axboe@...nel.dk> To: Shaohua Li <shaohua.li@...el.com> CC: Tejun Heo <tj@...nel.org>, Vivek Goyal <vgoyal@...hat.com>, lkml <linux-kernel@...r.kernel.org>, Knut Petersen <Knut_Petersen@...nline.de>, mroos@...ux.ee, Linus Torvalds <torvalds@...ux-foundation.org> Subject: Re: [PATCH block/for-linus 1/3] block: replace icq->changed with icq->flags On 2012-02-15 02:09, Shaohua Li wrote: > 2012/2/15 Tejun Heo <tj@...nel.org>: >> icq->changed was used for ICQ_*_CHANGED bits. Rename it to flags and >> access it under ioc->lock instead of using atomic bitops. >> ioc_get_changed() is added so that the changed part can be fetched and >> cleared as before. >> >> icq->flags will be used to carry other flags. >> >> Signed-off-by: Tejun Heo <tj@...nel.org> >> --- >> Jens, these three patches are to fix the swap heavy workload >> regression reported by Shaohua. >> >> Shaohua, I ended up changing the second patch, which shouldn't change >> anything but it would be great if you can verify this series once >> more. > yes, confirmed the patches fix the regression. Thanks for fixing it. > Tested-by: Shaohua Li <shaohua.li@...el.com> Great, thanks Tejun - and Shaohua for finding/reporting/testing. I'll get this applied. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists