[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1329317950-101579-1-git-send-email-bootc@bootc.net>
Date: Wed, 15 Feb 2012 14:59:07 +0000
From: Chris Boot <bootc@...tc.net>
To: linux1394-devel@...ts.sourceforge.net
Cc: linux-kernel@...r.kernel.org
Subject: [PATCH v2 0/3] firewire-sbp2: Various fixes
In writing my SBP-2 target code I found a few areas in the firewire-sbp2
initiator code that needed some attention:
1. The Unit_Unique_ID property in SBP-2 unit directories is ignored, but this
should be used when working out the target port name instead of the node's
GUID if it is present. (Suggestion of Stefan Richter)
2. The initiator tries to login to any and all SBP-2 targets, including ones on
the local node. This fails due to how the firewire stack / initiator code
works but is most likely undesirable behaviour, so this patch makes
firewire-sbp2 ignore SBP-2 targets on the local node.
3. SBP-2 sends SCSI sense data over the wire in an unusual format which
requires un-mangling before we can pass it to the SCSI subsystem. Some of
this mangling is currently being done incorrectly, so this patch fixes it.
Changes since v1:
* Don't fail on malformed Unit_Unique_ID properties, just ignore them
* Just return -ENODEV when we encounter the local node
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists