linux-kernel - Re: [PATCH 21/40] OpenRISC: Don't reimplement force

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1329320456.2670.86.camel@crucifix>
Date:	Wed, 15 Feb 2012 16:40:56 +0100
From:	Jonas Bonn <jonas@...thpole.se>
To:	Matt Fleming <matt@...sole-pimps.org>
Cc:	linux-arch@...r.kernel.org, Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Matt Fleming <matt.fleming@...el.com>,
	Arnd Bergmann <arnd@...db.de>, linux@...ts.openrisc.net
Subject: Re: [PATCH 21/40] OpenRISC: Don't reimplement force_sigsegv()


Acked-by: Jonas Bonn <jonas@...thpole.se>

...for OpenRISC, all 4 patches (20-23 in this series).

Should I take these in the OpenRISC tree or how did you want to do?

/Jonas

On Tue, 2012-02-14 at 11:40 +0000, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@...el.com>
> 
> Instead of open coding the sequence from force_sigsegv() just call
> it. This also fixes a bug because we were modifying ka->sa.sa_handler
> (which is a copy of sighand->action[]), whereas the intention of the
> code was to modify sighand->action[] directly.
> 
> As the original code was working with a copy it had no effect on
> signal delivery.
> 
> Acked-by: Oleg Nesterov <oleg@...hat.com>
> Cc: Jonas Bonn <jonas@...thpole.se>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: linux@...ts.openrisc.net
> Signed-off-by: Matt Fleming <matt.fleming@...el.com>
> ---
>  arch/openrisc/kernel/signal.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/openrisc/kernel/signal.c b/arch/openrisc/kernel/signal.c
> index 95207ab..53741ba 100644
> --- a/arch/openrisc/kernel/signal.c
> +++ b/arch/openrisc/kernel/signal.c
> @@ -250,9 +250,7 @@ static void setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
>  	return;
>  
>  give_sigsegv:
> -	if (sig == SIGSEGV)
> -		ka->sa.sa_handler = SIG_DFL;
> -	force_sig(SIGSEGV, current);
> +	force_sigsegv(sig, current);
>  }
>  
>  static inline void

-- 
Jonas Bonn                       South Pole AB
Phone : +46-8-56237100           Anderstorpsvägen 16
Mobile: +46-768-527755           SE-17154 Solna
jonas@...thpole.se               www.southpoleconsulting.com





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/