linux-kernel - Re: [PATCH] ARM: ptrace: Include linux/audit.h to fix build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1202151518000.24536@xanadu.home>
Date:	Wed, 15 Feb 2012 15:19:18 -0500 (EST)
From:	Nicolas Pitre <nicolas.pitre@...aro.org>
To:	Eric Paris <eparis@...hat.com>
cc:	Russell King - ARM Linux <linux@....linux.org.uk>,
	Axel Lin <axel.lin@...il.com>, linux-kernel@...r.kernel.org,
	Nathaniel Husted <nhusted@...il.com>,
	Will Deacon <will.deacon@....com>,
	Dave Martin <dave.martin@...aro.org>,
	Ingo Molnar <mingo@...e.hu>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: ptrace: Include linux/audit.h to fix build errors

On Wed, 15 Feb 2012, Eric Paris wrote:

> On Wed, 2012-02-15 at 17:34 +0000, Russell King - ARM Linux wrote:
> > On Wed, Feb 15, 2012 at 12:07:02PM -0500, Eric Paris wrote:
> > > So if someone tells me how the code knows it's endianness I'll gladly
> > > write the ifdef to switch from AUDIT_ARCH_ARMEB to AUDIT_ARCH_ARM when
> > > appropriate....
> > 
> > An easy way would be:
> > 
> > #ifndef __ARMEB__
> > #define AUDIT_ARCH_NR AUDIT_ARCH_ARMEB
> > #else
> > #define AUDIT_ARCH_NR AUDIT_ARCH_ARM
> > #endif
> 
> Is that actually exactly backwards?  ifndef?  (I don't have a clue 
> when __ARMEB__ is set)

__ARMEB__ is set on big endian.  So the above condition should be ifdef 
not ifndef.


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/