lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Feb 2012 13:23:10 -0800 From: Andrew Morton <akpm@...ux-foundation.org> To: Prashanth Nageshappa <prashanth@...ux.vnet.ibm.com> Cc: masami.hiramatsu.pt@...achi.com, ananth@...ibm.com, linux-kernel@...r.kernel.org, jbaron@...hat.com, rostedt@...dmis.org, srikar@...ux.vnet.ibm.com, stable@...r.kernel.org Subject: Re: [PATCH v2] Return proper error code from register_kprobe() On Wed, 15 Feb 2012 12:46:03 +0530 Prashanth Nageshappa <prashanth@...ux.vnet.ibm.com> wrote: > register_kprobe() aborts if the address of the new request falls in a > prohibited area (such as ftrace pouch, __kprobes annotated functions, I'm sitting here wondering what you meant to type when you typed "ftrace pouch". I'm stumped! But you're not allowed to tell us - that would take all the fun out of it. > non-kernel text addresses, jump label text). We however don't return the > right error on this abort, resulting in a silent failure - incorrect > adding/reporting of kprobes ('perf probe do_fork+18' or > 'perf probe mcount' for instance). > > In V2 we are incorporating Masami Hiramatsu's feedback. > > This patch fixes it by returning -EINVAL upon failure. > > While we are here, rename the label used for exit to be more appropriate. > > Signed-off-by: Ananth N Mavinakayanahalli <ananth@...ibm.com> > Signed-off-by: Prashanth K Nageshappa <prashanth@...ux.vnet.ibm.com> > Cc: stable@...r.kernel.org So we want this for 3.3 with a -stable backport. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists