linux-kernel - Re: [PATCH] Staging: crystalhd: crystalhd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120215064059.GO4141@mwanda>
Date:	Wed, 15 Feb 2012 09:40:59 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jorgyano Vieira <jorgyano@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: crystalhd: crystalhd_misc: improved debug macros

On Wed, Feb 15, 2012 at 12:20:06AM -0200, Jorgyano Vieira wrote:
> Improvement of debug macros to ensure safe use on if/else statements.
> 

How are the originals unsafe?  The changelog should say how this is
an improvement.  Something like "I put do { ... } while(0) around
the macros so it matches the rest of the kernel."

Really we want to get rid of these.  It would be easy to delete
BCMLOG_ENTER and BCMLOG_LEAVE right now.  They're only used for five
functions.  BCMLOG() is slightly complicated.  BCMLOG_ERR() could
be sed replaced with pr_err().

So could you do that instead?  Send a patch to remove BCMLOG_ENTER
and BCMLOG_LEAVE?  Then send another patch to replace BCMLOG_ERR()
with pr_err().  Take a look at how the pr_fmt macro is used for
this.  Don't actually do it with sed.  Take the time and review each
printk() and notice bugs as you go along.  You could replace them
file by file if you wanted or all at once, which ever is easier for
you.  Then send a third patch to add the do {} while(0) block to
BCMLOG() until someone works up enough motivation to fix it
properly?

regards,
dan carpenter

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)