linux-kernel - RE: [PATCH] pm8001: fix enum checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19540A16097A409F9E4999160E0B25BC@usish.com.cn>
Date:	Wed, 15 Feb 2012 09:02:51 +0800
From:	"Jack Wang" <jack_wang@...sh.com>
To:	"'Danny Kukawka'" <danny.kukawka@...ect.de>,
	"'James E.J. Bottomley'" <JBottomley@...allels.com>
Cc:	"'Danny Kukawka'" <dkukawka@...e.de>, <lindar_liu@...sh.com>,
	<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] pm8001: fix enum checks

Thanks for fix.
Acked-by: Jack Wang <jack_wang@...sh.com> 

[PATCH] pm8001: fix enum checks
> 
> Fix for:
> drivers/scsi/pm8001/pm8001_hwi.c: In function 'hw_event_sas_phy_up':
> drivers/scsi/pm8001/pm8001_hwi.c:2932:32: warning: comparison between
>   'enum sas_device_type' and 'enum sas_dev_type' [-Wenum-compare]
> drivers/scsi/pm8001/pm8001_hwi.c:2934:37: warning: comparison between
>   'enum sas_device_type' and 'enum sas_dev_type' [-Wenum-compare]
> 
> Changed SAS_END_DEV to SAS_END_DEVICE and NO_DEVICE with
> SAS_PHY_UNUSED.
> 
> Signed-off-by: Danny Kukawka <danny.kukawka@...ect.de>
> ---
>  drivers/scsi/pm8001/pm8001_hwi.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/pm8001/pm8001_hwi.c
> b/drivers/scsi/pm8001/pm8001_hwi.c
> index b7b92f7..46fd7219 100644
> --- a/drivers/scsi/pm8001/pm8001_hwi.c
> +++ b/drivers/scsi/pm8001/pm8001_hwi.c
> @@ -2929,9 +2929,9 @@ hw_event_sas_phy_up(struct pm8001_hba_info
*pm8001_ha,
> void *piomb)
>  	phy->phy_type |= PORT_TYPE_SAS;
>  	phy->identify.device_type = deviceType;
>  	phy->phy_attached = 1;
> -	if (phy->identify.device_type == SAS_END_DEV)
> +	if (phy->identify.device_type == SAS_END_DEVICE)
>  		phy->identify.target_port_protocols = SAS_PROTOCOL_SSP;
> -	else if (phy->identify.device_type != NO_DEVICE)
> +	else if (phy->identify.device_type != SAS_PHY_UNUSED)
>  		phy->identify.target_port_protocols = SAS_PROTOCOL_SMP;
>  	phy->sas_phy.oob_mode = SAS_OOB_MODE;
>  	sas_ha->notify_phy_event(&phy->sas_phy, PHYE_OOB_DONE);
> --
> 1.7.7.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/