linux-kernel - Re: [PATCH 3.3 v2] OMAP4: PRM: fix build breakage when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1329290402.19569.24.camel@cumari>
Date:	Wed, 15 Feb 2012 09:20:02 +0200
From:	Luciano Coelho <coelho@...com>
To:	Tony Lindgren <tony@...mide.com>
Cc:	linux@....linux.org.uk, linux-omap@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Tero Kristo <t-kristo@...com>
Subject: Re: [PATCH 3.3 v2] OMAP4: PRM: fix build breakage when CONFIG_OF is
 not defined

Hi Tony,

On Tue, 2012-02-14 at 12:38 -0800, Tony Lindgren wrote: 
> * Luciano Coelho <coelho@...com> [120208 02:43]:
> > Since 3.3-rc1, prm44xx.c build breaks if CONFIG_OF is not set:
> > 
> > arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here (not in a function)
> > make[1]: *** [arch/arm/mach-omap2/prm44xx.o] Error 1
> > 
> > This is because of a missing include, which is added indirectly if
> > CONFIG_OF is defined.  This problem was introduced in commit
> > 2f31b51 (ARM: OMAP4: PRM: use PRCM interrupt handler).
> > 
> > Cc: Tero Kristo <t-kristo@...com>
> > Signed-off-by: Luciano Coelho <coelho@...com>
> > Reviewed-by: Felipe Balbi <balbi@...com>
> 
> A similar patch should be already in mainline kernel queued by Russell.

Right, someone pointed this out to me after I sent the two patches.
Sorry for the trouble, I should have looked more carefully before
jumping in to fix this stuff. ;)

-- 
Cheers,
Luca.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/