linux-kernel - Re: [PATCH] watchdog: make imx2_wdt report boot status correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120216133510.GA2541@pengutronix.de>
Date:	Thu, 16 Feb 2012 14:35:10 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Oskar Schirmer <oskar@...ra.com>
Cc:	wim@...ana.be, s.hauer@...gutronix.de,
	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: make imx2_wdt report boot status correctly

Hi Oskar,

besides this minor thing (which may be just personal taste)...

> +	case WDIOC_GETBOOTSTATUS:
> +		val = __raw_readw(imx2_wdt.base + IMX2_WDT_WRSR);
> +		new_value = 0;
> +		if (val & IMX2_WDT_WRSR_TOUT)
> +			new_value = WDIOF_CARDRESET;

I'd go for this to save some lines:
		new_value = val & IMX2_WDT_WRSR_TOUT ? WDIOF_CARDRESET : 0;

But in general:

Acked-by: Wolfram Sang <w.sang@...gutronix.de>


-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)