linux-kernel - Re: Regression 3.2 -> 3.3-rc1 10 sec hang at boot and resume, COMRESET failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F3D2D55.8000104@garzik.org>
Date:	Thu, 16 Feb 2012 11:22:45 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Brian Norris <computersforpeace@...il.com>
CC:	Tejun Heo <tj@...nel.org>, Lin Ming <ming.m.lin@...el.com>,
	Norbert Preining <preining@...ic.at>,
	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org,
	"stern@...land.harvard.edu >> Alan Stern" <stern@...land.harvard.edu>,
	linux-ide@...r.kernel.org,
	Linux PM mailing list <linux-pm@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Jian Peng <jipeng2005@...il.com>,
	Kevin Cernekee <cernekee@...il.com>, valdis.kletnieks@...edu,
	Mark Lord <kernel@...savvy.com>
Subject: Re: Regression 3.2 -> 3.3-rc1 10 sec hang at boot and resume, COMRESET
 failed

On 02/15/2012 06:39 PM, Brian Norris wrote:
> On Wed, Feb 15, 2012 at 11:18 AM, Jeff Garzik<jeff@...zik.org>  wrote:
>> On 02/15/2012 01:31 PM, Tejun Heo wrote:
>>> The problem is that there's no way to identify the controller in
>>> question, so we can't do this automatically, so might just as well do
>>> it in the simplest way for now.  :(
>>
>>
>> See ahci_devtype[] and ahci_port_info[] in ahci_platform.c for how to do
>> this.  Brian would not have to tweak the driver out of tree as claimed; we
>> put all changes in tree, and the platform calls itself "spec-strict-ahci" or
>> whatever string you prefer.
>
> OK, so can it seems I would add a flag in include/linux/libata.h that
> can be added to a new entry in ahci_port_info[]? It seems a little
> awkward to put in "libata.h", plus I'm not sure if all the flags have
> direct meaning to ATA or if they can be AHCI-specific.

Nothing needs to go into libata.h.  grep for IMX53_AHCI, and see how 
that differentiates ata_port_info information.  There you may vary 
AHCI-specific flags (defined in ahci.h), port operations, or anything 
else specific to the controller.

Create a flag, add it to ahci.h, guard the spec-strict behavior creating 
problems with said flag, and apply said flag to your controller in 
ahci_platform.

	Jeff


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/