linux-kernel - Re: [PATCH V2 1/2] mfd: Add driver for STA2X11 MFD block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYV7-a4o+gucUXEbQb1=MHC-7tZ6Hv+jGcpiTiD1DqQNA@mail.gmail.com>
Date:	Thu, 16 Feb 2012 20:29:24 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Alessandro Rubini <rubini@...dd.com>
Cc:	linux-kernel@...r.kernel.org, giancarlo.asnaghi@...com,
	alan@...ux.intel.com, sameo@...ux.intel.com,
	grant.likely@...retlab.ca, linus.walleij@...ricsson.com
Subject: Re: [PATCH V2 1/2] mfd: Add driver for STA2X11 MFD block

On Thu, Feb 16, 2012 at 2:00 PM, Alessandro Rubini <rubini@...dd.com> wrote:

> +config MFD_STA2X11
> +       bool "STA2X11 multi function device support"
> +       depends on STA2X11
> +       select MFD_CORE
> +       select GPIO_STA2X11

Note: this selects a non-existent driver at this point. (OK no big deal.)

> +/* Give names to GPIO pins, like PXA does, taken from the manual */
> +#define GPIO0                  0
> +#define GPIO1                  1
> +#define GPIO2                  2
(...)

These are too general names I think. It should be clear that this is the
GPIO number relative to this one controller, so I would prefix them
like STA2X11_GPIO0 etc.

Overall the MFD core for STA2X11 is looking pretty good!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/