linux-kernel - Re: misc: hpilo patch for increasing max channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20120216000741.GA21792@kroah.com>
Date:	Wed, 15 Feb 2012 16:07:41 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	"Rusk, Mark" <mark.rusk@...com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: misc: hpilo patch for increasing max channels

On Wed, Oct 05, 2011 at 04:57:56PM +0100, Rusk, Mark wrote:
> This patch is to allow for hpilo to support more channels (from 8 to 24) and this is configurable.
> The module parameter, max_ccb, is also readable from /sys/module/hpilo/parameters/max_ccb.
> 
> Signed-off-by: Mark Rusk <mark.rusk@...com>
> 
> --- drivers/misc.old/hpilo.c    2011-10-04 17:37:59.000000000 -0500
> +++ drivers/misc/hpilo.c        2011-10-04 17:15:02.000000000 -0500

Please send patches that can be applied with 'patch -p1', as that is
what our tools assume.  Documentation/SubmittingPatches goes into this
quite well.


> @@ -878,11 +883,14 @@
>         class_destroy(ilo_class);
>  }
> 
> -MODULE_VERSION("1.3");
> +MODULE_VERSION("1.2");

Why did you just decrement the module version?

Care to resend this in a format that I can apply it in, after verifying
that you really want to go down in the module version number?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/