linux-kernel - Re: Please add irqdomain branch to linux-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1329361898.3772.43.camel@pasglop>
Date:	Thu, 16 Feb 2012 14:11:38 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next <linux-next@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: Please add irqdomain branch to linux-next

On Wed, 2012-02-15 at 18:32 -0700, Grant Likely wrote:

> Only nomap users will care about this, and of those 5, only iseries
> and ps3 actually change it.  How about I add a max_virq parameter to
> only be used by the nomap revmap?  That seems to be cleaner than a
> global setting.  I've crafted a patch and will post it with v5 of the
> series.

Right, I don't see an obvious need elsewhere so it could be a flag
specific to nomap, tho it still needs to be taken into account in the
main allocation code.

> For now I'll use numa_node_id() at allocation time.  I'll craft a
> follow-on patch to change the API since it touches a lot of call
> sites.

But which node ? :-)

I'd rather you add a new API, no need to change the call sites:

Add foo_node(xxx,node); and have the existing foo() be implemented
as a static inline calling foo_node(xxx,0); or something like that, then
I can change the powerpc code to use the later & pass the PCI device
node (which should be in the pci_controller structure). We can add more
later.

> I've dropped irq_domain_xlate_pci()
> 
> I think I've addressed all the problems you've brought up.  I'm
> testing now and I'll be posting v5 very shortly.

Ok, let me know.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/