lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 17 Feb 2012 14:27:39 +0530
From:	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
To:	Marcos Paulo de Souza <marcos.mage@...il.com>
CC:	lenb@...nel.org, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/idle/intel_idle.c: Fix confusing code identation

On 02/17/2012 02:13 PM, Marcos Paulo de Souza wrote:

> Suggested-by: Srivatsa S. Bhat <srivatsa.bhat@...ux.vnet.ibm.com>
> Signed-off-by: Marcos Paulo de Souza <marcos.mage@...il.com>
> ---


Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@...ux.vnet.ibm.com>

[ A small commit message wouldn't hurt though :-) ]

Regards,
Srivatsa S. Bhat

>  drivers/idle/intel_idle.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index 54ab97b..5e71b98 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -495,8 +495,7 @@ int intel_idle_cpu_init(int cpu)
>  		int num_substates;
> 
>  		if (cstate > max_cstate) {
> -			printk(PREFIX "max_cstate %d reached\n",
> -			       max_cstate);
> +			printk(PREFIX "max_cstate %d reached\n", max_cstate);
>  			break;
>  		}
> 
> @@ -512,8 +511,9 @@ int intel_idle_cpu_init(int cpu)
>  		dev->states_usage[dev->state_count].driver_data =
>  			(void *)get_driver_data(cstate);
> 
> -			dev->state_count += 1;
> -		}
> +		dev->state_count += 1;
> +	}
> +
>  	dev->cpu = cpu;
> 
>  	if (cpuidle_register_device(dev)) {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists