linux-kernel - Re: [PATCH 2/2] ARM: dma-mapping: fix leak in consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB4K4y7RSwTLZq_N4jY3vDGYCmde-CTvVH5sBdzYfaiPsJMmGA@mail.gmail.com>
Date:	Fri, 17 Feb 2012 18:58:33 +0530
From:	Ajeet Yadav <ajeet.yadav.77@...il.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Jon Medhurst <tixy@...t.co.uk>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Sumit Bhattacharya <sumitb@...dia.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dma-mapping: fix leak in consistent_init

thank you for kind review, but how can I resent the patch using same mail chain

git send-email --smtp-encryption=tls --smtp-server=smtp.gmail.com
--smtp-user=ajeet.yadav.77@...il.com --smtp-server-port=587 --from
"Ajeet Yadav <ajeet.yadav.77@...il.com>" --to "Russell King
<linux@....linux.org.uk>" --to "Jon Medhurst <tixy@...t.co.uk>" --to
"Nicolas Pitre <nicolas.pitre@...aro.org>" --to "Catalin Marinas
<catalin.marinas@....com>" --to "Sumit Bhattacharya
<sumitb@...dia.com>" --to "linux-arm-kernel@...ts.infradead.org" --to
"linux-kernel@...r.kernel.org"
0002-ARM-dma-mapping-fix-leak-in-consistent_init.patch

On Fri, Feb 17, 2012 at 6:42 PM, Russell King - ARM Linux
<linux@....linux.org.uk> wrote:
> On Fri, Feb 17, 2012 at 06:39:55PM +0530, Ajeet Yadav wrote:
>> Although the error in this case is unlikely, but logically
>> if error occurs then we leak memory.
>>
>> Signed-off-by: Ajeet Yadav <ajeet.yadav.77@...il.com>
>> ---
>>  arch/arm/mm/dma-mapping.c |   24 ++++++++++++------------
>>  1 files changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
>> index 04bfa76..b8cf062 100644
>> --- a/arch/arm/mm/dma-mapping.c
>> +++ b/arch/arm/mm/dma-mapping.c
>> @@ -161,7 +161,6 @@ static struct arm_vmregion_head consistent_head = {
>>   */
>>  static int __init consistent_init(void)
>>  {
>> -     int ret = 0;
>>       pgd_t *pgd;
>>       pud_t *pud;
>>       pmd_t *pmd;
>> @@ -171,7 +170,7 @@ static int __init consistent_init(void)
>>       unsigned long num_ptes = (CONSISTENT_END - base) >> PMD_SHIFT;
>>
>>       consistent_pte = kmalloc(num_ptes * sizeof(pte_t *), GFP_KERNEL);
>> -     if (!consistent_pte) {
>> +     if (unlikely(!consistent_pte)) {
>
> Please get rid of these unlikelys.  This really isn't a performance
> critical path.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/