linux-kernel - Re: [PATCH] mm: add config NUMA stub to all architectures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 Feb 2012 14:44:04 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Konstantin Khlebnikov <khlebnikov@...nvz.org>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: add config NUMA stub to all architectures

On Fri, Feb 17, 2012 at 05:32:10PM +0400, Konstantin Khlebnikov wrote:
> Stephen Rothwell wrote:
>> Hi Konstantin,
>>
>> On Fri, 17 Feb 2012 16:08:15 +0400 Konstantin Khlebnikov<khlebnikov@...nvz.org>  wrote:
>>>
>>> Config NUMA must be defined for all architectures,
>>> otherwise IS_ENABLED(CONFIG_NUMA) does not work.
>>> Some arch-specific Kconfig already has this stub.
>>> This patch adds it to all remaining.
>>
>> Why not add it somewhere generic (like mm/Kconfig, maybe) and then it can
>> be removed from the architecture specific places over time (if necessary
>> - I am pretty sure it is ok to have it there twice)?
>>
>
> Different architectures has different dependencies for NUMA.
>
> Seems like Kconfig allow config option duplication, but it use default state from first.
> If we add "config NUMA\n def_bool n" somewhere in generic Kconfig, default will be n if
> Kconfig see this declaration first.
Correct.
And as n is default there is no need to specify it.
But please add a help text that explain the symbol - even if it is not
visible in menuconfig.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/