linux-kernel - Re: [PATCH] fix modpost when CONFIG_ALPHA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F40264E.6050602@orcon.net.nz>
Date:	Sun, 19 Feb 2012 11:29:34 +1300
From:	Michael Cree <mcree@...on.net.nz>
To:	Jim Faulkner <jfaulkne@....neu.edu>
CC:	linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, gregkh@...uxfoundation.org,
	rth@...ddle.net, ink@...assic.park.msu.ru, mattst88@...il.com,
	torvalds@...ux-foundation.org, jay.estabrook@...il.com
Subject: Re: [PATCH] fix modpost when CONFIG_ALPHA_TSUNAMI=y

On 19/02/12 10:24, Jim Faulkner wrote:
> Linux 3.2.6 fails to modpost on my alpha machine when
> CONFIG_ALPHA_TSUNAMI=y.  Linux 3.3-rc3 does not appear to have a fix for
> this bug, so is likely also affected.  I've attached a patch which fixes
> this issue.  I have tested this patch on Linux 3.2.6 successfully, and
> the patch also applies cleanly to Linux 3.3-rc3.

> diff -uNr linux-3.3-rc3/arch/alpha/kernel/core_tsunami.c linux-3.3-rc3.patched/arch/alpha/kernel/core_tsunami.c
> --- linux-3.3-rc3/arch/alpha/kernel/core_tsunami.c	2012-02-08 22:21:53.000000000 -0500
> +++ linux-3.3-rc3.patched/arch/alpha/kernel/core_tsunami.c	2012-02-18 16:07:12.859977887 -0500
> @@ -11,6 +11,7 @@
>  #include <asm/core_tsunami.h>
>  #undef __EXTERN_INLINE
>  
> +#include <linux/module.h>

Wouldn't <linux/exports.h> be better?  I seem to recall that this was a
problem with EXPORT_SYMBOL not being defined and I see my own personal
fix (which I had completely forgotten to send upstream) was to include
<linux/exports.h>

>  #include <linux/types.h>
>  #include <linux/pci.h>
>  #include <linux/sched.h>

Cheers
Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/