linux-kernel - Re: [PATCH 3/3] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120218064039.GD2912@mwanda>
Date:	Sat, 18 Feb 2012 09:40:39 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Jorgyano Vieira <jorgyano@...il.com>, gregkh@...uxfoundation.org,
	devel@...uxdriverproject.org, jarod@...sonet.com,
	nsankar@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Staging: crystalhd: Replace the BCMLOG_ERR macro
 with pr_err

On Fri, Feb 17, 2012 at 10:30:25PM -0800, Joe Perches wrote:
> On Sat, 2012-02-18 at 09:25 +0300, Dan Carpenter wrote:
> > On Fri, Feb 17, 2012 at 09:39:36PM -0200, Jorgyano Vieira wrote:
> > > Replace the usage of BCMLOG_ERR with pr_err and remove the macro definition.
> > This needs a pr_fmt line so we can tell where the errors are coming
> > from.
> > #define pr_fmt(fmt)     KBUILD_MODNAME ": %s:%d: " fmt, __func__, __LINE__
> 
> True.
> __func__ and __LINE__ are not generally useful though.
> 

If you don't know the function and line number, then how do you
tell all the "Invalid args" printks apart?

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)