linux-kernel - Re: [PATCH 3/3] w1: add slave driver for DS1996 and DS1963L

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120218103947.GB13028@ioremap.net>
Date:	Sat, 18 Feb 2012 13:39:47 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Michael Thalmeier <michael.thalmeier@...e.at>
Cc:	linux-kernel@...r.kernel.org, michael@...lmeier.at
Subject: Re: [PATCH 3/3] w1: add slave driver for DS1996 and DS1963L

Hi

On Fri, Feb 17, 2012 at 01:07:02PM +0100, Michael Thalmeier (michael.thalmeier@...e.at) wrote:
> This driver adds support for some Dallas non-volatile memory 1-wire slave
> devices.
> 
> At the moment the following devices are supported:
> 
>  * family 0x0c: DS1996 64Kb Memory iButton
>  * family 0x1A: DS1963L 4kbit Monetary
> 
> Access to memory is done via pages exportedi in sysfs.
> 
> Signed-off-by: Michael Thalmeier <michael.thalmeier@...e.at>

Looks good to me, although I would replace config option 
with sysfs-enabled parameter, since distros do not compile different
kernels with various options enabled.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/