linux-kernel - Re: [PATCH 3/3] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABRD5h+B-CzNQ+0+ahEBet7-N3O7Hh2BLQVwJzW7As_0UNs69w@mail.gmail.com>
Date:	Sat, 18 Feb 2012 11:36:15 -0200
From:	Jorgyano vieira <jorgyano@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	gregkh@...uxfoundation.org, devel@...uxdriverproject.org,
	jarod@...sonet.com, nsankar@...adcom.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err

> It's possible to add "%s...", __func__ to
> the necessary uses.  Adding it to the generic
> is likely overkill.
I agree with that.

> But is it really necessary anyway?
>
> Aren't those called via some specific notifier
> such that the output would make sense given
> some specific invalid input?
Some messages like "Invalid Arg" and "Invalid len" really don't make
sense as it is.

But I think that just adding __func__ to the necessary uses is enough.
I will resend this patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/