linux-kernel - re: w1: Fix w1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120218205125.GA26827@elgon.mountain>
Date:	Sat, 18 Feb 2012 23:51:25 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	neilb@...e.de
Cc:	linux-kernel@...r.kernel.org
Subject: re: w1: Fix w1_bq27000

Hello NeilBrown,

This is a semi-automatic email about new static checker warnings.

The patch 9f3519d2ed26: "w1: Fix w1_bq27000" from Feb 15, 2012, leads 
to the following Smatch complaint:

drivers/w1/slaves/w1_bq27000.c:48 w1_bq27000_read()
	 warn: variable dereferenced before check 'dev' (see line 46)

drivers/w1/slaves/w1_bq27000.c
    45		u8 val;
    46		struct w1_slave *sl = container_of(dev->parent, struct w1_slave, dev);
                                                   ^^^^^^^^^^^
New dereference.

    47	
    48		if (!dev)
                     ^^^
Old check.

    49			return 0;
    50	

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/