linux-kernel - Re: [PATCH] 8139cp: reject invalid MTU values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120219.185420.1710587455826987655.davem@davemloft.net>
Date:	Sun, 19 Feb 2012 18:54:20 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	pbonzini@...hat.com
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] 8139cp: reject invalid MTU values

From: Paolo Bonzini <pbonzini@...hat.com>
Date: Fri, 17 Feb 2012 13:33:15 +0100

> The 8139cp driver has a change_mtu function that has not been
> enabled since the dawn of the git repository.  However, the
> generic eth_change_mtu is not used in its place, so that
> invalid MTU values can be set on the interface.
> 
> This patch salvages the broken code for the single case of
> setting the MTU while the interface is down, which is safe
> and also includes the range check.

Well, now you can't change the MTU while the device is up
which to me is a worse problem than MTU validation because
this breaks valid things that potentially worked previously.

Also you didn't bother to give your patch a proper signoff.

You're going to have to fix cp_change_mtu() so that it does the
correct HW reset sequence when the MTU changes, otherwise I am not
going to apply this patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/